Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow remote playback device to choose the remote playback source. #141

Merged
merged 4 commits into from
Nov 10, 2020
Merged

Allow remote playback device to choose the remote playback source. #141

merged 4 commits into from
Nov 10, 2020

Conversation

markafoltz
Copy link
Contributor

@markafoltz markafoltz commented Oct 14, 2020 •
edited by pr-preview bot
Loading

This addresses Issue #125: RemotePlaybackState enum can become misleading when changing media.src.

It clarifies that:

  1. All media resources in a media element are eligible for remote playback
  2. Metadata about all the media resources may be sent to the remote playback device, so it can choose the remote playback source

Some more clarification could be done:

  • Adding a step to 5.2.4 ("Establishing a connection with a remote playback device") to indicate when the selection of the remote playback source happens. (Instead, I updated a non-normative note at the end of these steps.)
  • Clarifying what happens when remote playback is disconnected, i.e. does the user agent automatically revert to the .currentSrc that was playing before remote playback was initiated.

Let me know if you want further changes along these lines.

Preview | Diff

@markafoltz markafoltz self-assigned this Oct 14, 2020
@markafoltz
Copy link
Contributor Author

PTAL @mounirlamouri @jernoble

@markafoltz markafoltz linked an issue Oct 14, 2020 that may be closed by this pull request
RemotePlaybackState enum can become misleading when changing media.src #125
Closed
baylesj
baylesj reviewed Oct 14, 2020
View reviewed changes
Copy link

@baylesj baylesj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the behavior on remote playback end is implementation specific or not, so if we expect that to be standardized (versus the implementation-specific playback source selection mechanism) I'd like to see that in this document.

I think the note for 5.2.4 is fine as is.

index.html Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@markafoltz markafoltz mentioned this pull request Oct 15, 2020
Open
mounirlamouri
mounirlamouri reviewed Oct 20, 2020
View reviewed changes
index.html Outdated Show resolved Hide resolved
@jernoble
Copy link

LGTM.

@anssiko
Copy link
Member

anssiko commented Nov 3, 2020

It seems @jernoble LGTM'd this PR conditional to @mounirlamouri's proposal #141 (comment) baked in?

@mfoltzgoogle feel free to update the PR per the proposal and try to get quick confirmation from @mounirlamouri and/or @baylesj and @jernoble prior to merge.

@markafoltz
Copy link
Contributor Author

Updated the PR per the proposal from @mounirlamouri.

I also moved a separate note regarding source selection to this part of the spec, so that all the discussion of source selection is now in this section.

@mounirlamouri @baylesj @jernoble PTAL

@markafoltz markafoltz merged commit 1612ad8 into gh-pages Nov 10, 2020
@markafoltz markafoltz deleted the issue-125 branch November 10, 2020 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baylesj baylesj baylesj left review comments

@mounirlamouri mounirlamouri mounirlamouri approved these changes

Assignees

@markafoltz markafoltz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RemotePlaybackState enum can become misleading when changing media.src
5 participants
@markafoltz @jernoble @anssiko @mounirlamouri @baylesj